Brave Scot

Scots, wha hae wi' Wallace bled,
Scots, wham Bruce has aften led;
Welcome to your gory bed,

Or to victorie!

—"Bannockburn", poem by Robert Burns

The Scottish people are stereotypically brave fighters. Thus, a Scottish accent is sometimes used to emphasize the boldness of fantasy warriors. Accent quality may vary.

Compare Violent Glaswegian.

Examples of Brave Scot include:

Fan Fiction

A Scotsman in Egypt runs off this trope.
Minerva McGonagall frequently gets this treatment in Harry Potter fics—as befits the Head of Gryffindor House.

Film

Braveheart has William Wallace.
The adults in How to Train Your Dragon have Scottish accents (although they are supposed to be Vikings), but the kids do not, for some reason.
- Perhaps they wait for adulthood to put on their regimental accent.
Star Trek - Montgomery Scott, although he's more of a badass engineer than a true fighter.
In the Tim Burton film Alice in Wonderland, the Mad Hatter, during his occasional bouts of lucidity and badassery, slips into a Scottish accent.
Connor MacLeod, and any other Scottish Scottish characters.
Pixar's Brave is set in Scotland, so naturally everyone has the accent.
Gutsy Smurf, portrayed as a kilt-wearing Smurf with a Scottish accent, in The Smurfs live-action movie.

Literature

The Nac Mac Feegle from Discworld combine this with Violent Glaswegian.
The Honor Harrington series has denizens of Gryphon in general and Anton Zilwicki in particular, from another Fantasy Counterpart Culture
Jamie and his True Companions in Outlander.
Battlefield Earth: Johnny Tyler recruits a band of genetically brave Scots: brave enough to mine gold for an Machiavellian alien who is viciously insane, then willing to attempt to bring down a pan-galactic empire using souped-up machines guns and some ancient atomic weapons.
David Weber and Steve White's Starfire has Angus MacRory from a Fantasy Counterpart Culture
And then there's Prince Roger Ramius Sergei Chiang MacClintock and his ancestors. Yeah, Weber's pretty much in love with this trope.
Although Lord Brandoch Daha from E. R. Eddison's The Worm Ouroboros does not speak with a Scottish accent and has no other obvious Scottish traits, his motto (inscribed above his castle's gate) is surprisingly composed in (something that sounds like) Scots:

Ye braggers an' 'a'
Be skeered and awa'
Frae Brandoch Daha!

John Cleese wrote an article allegedly describing various threat level changes in Europe in response to 2015 fighting in Syria.

The Scots have raised their threat level from “Pissed Off” to “Let’s Get the Bastards.” They don’t have any other levels. This is the reason they have been used on the front lines of the British army for the last 300 years.

Live Action TV

Doctor Who has Jamie MacCrimmon.
- And Amy Pond, who can be something of a Badass.
Raven from Raven.
Duncan MacLeod, from Highlander the Series, primarily in flashbacks to his early years.
When asked what he brings to the Power Rangers' team dynamic, selfless protector of the weak and Big Guy Flynn McAllistair simply replies, "I'M SCOTTISH!"
Unlike the rest of the Northerners in Game of Thrones who speak with north country accents, the Badass Young Conqueror Robb Stark has traces of a scottish accent. This may or may not be just the actors normal accent slipping through.

Music

"Scotland the Brave," of course.

Video Games

In Team Fortress 2, the Demoman is this when he's on your team. He's the Violent Glaswegian on the opposite team (just like the Heavy is the Big Guy and the sniper is friendly on your team).
In the Total War series the Scots, quite naturally, have troops with slightly higher morale than other armies. They're not exceptionally high, though, and if you charge a regiment of Highlander light infantry into a meatgrinder with powerful heavy infantry like Dismounted Knights, the Highlanders are still going to break pretty quickly.
Sebastian Vael of Dragon Age II is a Brave Starkhaven Religious Bruiser, with Starkhaven being a rather patchy Fantasy Counterpart Culture version of Scotland.
Imperial Guard tank crews in Dawn Of War 2 are a mix of this and a Star Trek Shout-Out.
In Europa Universalis 3, Scotland gets three unique, powerful combat modifiers when they're at war with England.

Western Animation

The Scotsman from Samurai Jack.
Duff Killigan from Kim Possible.
Hudson and Macbeth are the two most notable examples from Gargoyles. Interesting to note, even though most of the Gargoyles themselves come from Scotland, only Hudson has a Scottish accent, even though all human characters from Scotland do.
Scrooge McDuck of DuckTales (1987) didn't make all that money sitting behind a desk.

Truth in Television

In the Ramada in York, the fire advisory signs say "Do not take unnecessary risks, but if possible, attack the fire with the instruments provided." In Edinburgh? "Attack the fire with the instruments provided."
And, of course, there's the man who kicked a terrorist--who was on fire at the time--in the balls so hard that the kicker sprained his foot in the aftermath of the Glasgow airport bombing.
The Gurkhas adopted the Highlanders as Blood Brothers after a joint Crowning Moment of Awesome in the 1800's. Need you ask more?
Scotland gets hit by a powerful storm with winds of up to 165mph, and their first reaction? Laugh and make merry by nicknaming the weather system, "Hurricane Bawbag".
There's a reason it was called The British Empire and not the French Empire...
This print.

Meta